wolflex888 commented on code in PR #1164:
URL: https://github.com/apache/polaris/pull/1164#discussion_r2045040810
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -398,9 +398,18 @@ public Response loadTable(
.loadTableIfStale(tableIdentifier, ifNoneMatch, snapshots)
.orElseThrow(() -> new
WebApplicationException(Response.Status.NOT_MODIFIED));
} else {
+ String credentialsEndpoint =
+ String.format(
+ "/v1/%s/namespaces/%s/tables/%s/credentials",
+ prefix, tableIdentifier.namespace().toString(),
tableIdentifier.name());
response =
catalog
- .loadTableWithAccessDelegationIfStale(tableIdentifier,
ifNoneMatch, snapshots)
+ .loadTableWithAccessDelegationIfStale(
+ tableIdentifier,
+ ifNoneMatch,
+ snapshots,
+ delegationModes,
+ RESTUtil.decodeString(credentialsEndpoint))
Review Comment:
I created a function to do the injection at the proper level. Let me know if
that's what you have in mind! Thanks for all the feedback! really appreciate it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
