singhpk234 commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2069062615
########## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ########## @@ -93,11 +93,7 @@ public void writeEntity( boolean nameOrParentChanged, PolarisBaseEntity originalEntity) { try { - datasourceOperations.runWithinTransaction( - statement -> { - persistEntity(callCtx, entity, originalEntity, statement); - return true; - }); + persistEntity(callCtx, entity, originalEntity, datasourceOperations); Review Comment: I updated the pr description, to be apt, please let me know how you fell now. Addressing the if else code meanwhile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org