eric-maynard commented on code in PR #1496:
URL: https://github.com/apache/polaris/pull/1496#discussion_r2069304325
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -143,12 +138,12 @@ private void persistEntity(
@Nonnull PolarisCallContext callCtx,
@Nonnull PolarisBaseEntity entity,
PolarisBaseEntity originalEntity,
- Statement statement)
+ CheckedFunction<String, Integer> fn)
Review Comment:
I see. I didn't realize it's used for the different functions in
`Statement`. Fundamentally I guess it's something like:
```
public class QueryAction {
/** Returns the number of affected rows */
public int apply(String statement);
}
```
But using a @FunctionalInterface makes sense. For the name, maybe we can
just call it as `queryConsumer` or `queryAction` or something to make it clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
