eric-maynard commented on code in PR #1840: URL: https://github.com/apache/polaris/pull/1840#discussion_r2140906398
########## polaris-core/src/main/java/org/apache/polaris/core/secrets/UnsafeInMemorySecretsManager.java: ########## @@ -45,6 +43,8 @@ public class UnsafeInMemorySecretsManager implements UserSecretsManager { private static final String CIPHERTEXT_HASH = "ciphertext-hash"; private static final String ENCRYPTION_KEY = "encryption-key"; + private static final String SECRET_MANAGER_TYPE = "unsafe-in-memory"; Review Comment: Can we make a static constant like `UnsafeInMemorySecretsManager.prefix`? (NID?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org