eric-maynard commented on code in PR #1840:
URL: https://github.com/apache/polaris/pull/1840#discussion_r2146023098
##########
polaris-core/src/main/java/org/apache/polaris/core/secrets/UnsafeInMemorySecretsManager.java:
##########
@@ -73,9 +73,9 @@ public UserSecretReference writeSecret(
String secretUrn;
for (int secretOrdinal = 0; ; ++secretOrdinal) {
+ String typeSpecificIdentifier = forEntity.getId() + ":" + secretOrdinal;
secretUrn =
- String.format(
- "urn:polaris-secret:unsafe-in-memory:%d:%d", forEntity.getId(),
secretOrdinal);
+ UserSecretReferenceUrnHelper.buildUrn(SECRET_MANAGER_TYPE,
typeSpecificIdentifier);
Review Comment:
Yeah it looks good, though seems like callers could just directly use
`UserSecretReference.buildUrnString`. If there's a situation where the
implementation might diverge, having the additional `buildUrn` method makes
sense. My original comment was more about the necessity of
`UserSecretReferenceUrnHelper`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
