poojanilangekar commented on code in PR #1840:
URL: https://github.com/apache/polaris/pull/1840#discussion_r2143311889
##########
polaris-core/src/main/java/org/apache/polaris/core/secrets/UserSecretReference.java:
##########
@@ -88,8 +88,7 @@ public UserSecretReference(
*/
@JsonIgnore
public String getUserSecretManagerTypeFromUrn() {
- // TODO: Add better/standardized parsing and validation of URN syntax
- return urn.split(":")[2];
+ return UserSecretReferenceUrnHelper.getSecretManagerType(urn);
Review Comment:
I did this to avoid mixing static and non-static methods in the
`UserSecretReference` class. Currently, `UserSecretReference` is only
instantiated when we have a secret that needs to stored and retrieved.
If you think that's okay, I can remove the helper and move its functionality
to `UserSecretReference`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
