sfc-gh-ygu commented on code in PR #2518:
URL: https://github.com/apache/polaris/pull/2518#discussion_r2349603222
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##########
@@ -194,7 +194,7 @@ Page<PolarisBaseEntity> loadEntities(
*/
@Nonnull
CreatePrincipalResult createPrincipal(
- @Nonnull PolarisCallContext callCtx, @Nonnull PolarisBaseEntity
principal);
+ @Nonnull PolarisCallContext callCtx, @Nonnull PrincipalEntity principal);
Review Comment:
Hi @XN137 , thanks for the refactor, the changes LGTM overall. However,
this interface change impacts all downstream projects. Can you start a dev mail
thread for awareness and potential deprecation process?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
