XN137 commented on code in PR #2518:
URL: https://github.com/apache/polaris/pull/2518#discussion_r2387793265
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##########
@@ -194,7 +194,7 @@ Page<PolarisBaseEntity> loadEntities(
*/
@Nonnull
CreatePrincipalResult createPrincipal(
- @Nonnull PolarisCallContext callCtx, @Nonnull PolarisBaseEntity
principal);
+ @Nonnull PolarisCallContext callCtx, @Nonnull PrincipalEntity principal);
Review Comment:
sorry i was out for 1,5 weeks.
started the ML discussion here:
https://lists.apache.org/thread/cflfhx59942kx29mtmthns5oo12dyzdv
wondering: what kind of timeframe do we need to wait for incoming opinions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
