dimas-b commented on code in PR #2518:
URL: https://github.com/apache/polaris/pull/2518#discussion_r2389565586
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/dao/entity/CreatePrincipalResult.java:
##########
@@ -67,10 +71,22 @@ private CreatePrincipalResult(
super(returnStatus, extraInformation);
this.principal = principal;
this.principalSecrets = principalSecrets;
+ validate();
Review Comment:
From my POV, it is fair to remove the `validate()` call from this
constructor.
I wonder, though, why is it a `@JsonCreator` at all... I do not see how
these objects could be instanciated from JSON 🤔 Did I miss something? 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
