dimas-b commented on code in PR #2711:
URL: https://github.com/apache/polaris/pull/2711#discussion_r2395949330
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCacheKey.java:
##########
@@ -69,6 +73,7 @@ static StorageCredentialCacheKey of(
allowedListAction,
allowedReadLocations,
allowedWriteLocations,
- refreshCredentialsEndpoint);
+ refreshCredentialsEndpoint,
+ credentialsRequired);
Review Comment:
> Do we have some general use-case of the credentialsRequired on gcp and
azure
My first attempt in this PR was do enforce credential presence close to the
REST level, but it proved to have too wide a ripple effect because many use
cases (including PyIceberg) request credential vending by default and that
breaks on FILE storage.
I'll see if I can refactor the code to maintain cache validity, but still
delegate config validation to storage integrations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
