HonahX commented on code in PR #2711:
URL: https://github.com/apache/polaris/pull/2711#discussion_r2400019423
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageIntegration.java:
##########
@@ -40,7 +40,7 @@ public PolarisStorageIntegration(T config, String
identifierOrId) {
this.integrationIdentifierOrId = identifierOrId;
}
- protected T config() {
Review Comment:
Seems to be unrelated change?
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageIntegration.java:
##########
@@ -108,6 +108,14 @@ public abstract AccessConfig getSubscopedCreds(
@Nonnull Set<PolarisStorageActions> actions,
@Nonnull Set<String> locations);
+ /**
+ * @param credentialsRequired if {@code true} indicates that the caller
requires the returned
+ * {@link AccessConfig} to have storage credentials; if {@code false}
the returned {@link
+ * AccessConfig} may or may not contain credentials.
+ */
+ public void validateCredentials(
+ @Nonnull AccessConfig accessConfig, boolean credentialsRequired) {}
Review Comment:
Seems this is not used?
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/TransactionalMetaStoreManagerImpl.java:
##########
@@ -2093,6 +2093,7 @@ private PolarisEntityResolver resolveSecurableToRoleGrant(
PolarisStorageIntegration<PolarisStorageConfigurationInfo>
storageIntegration =
ms.loadPolarisStorageIntegrationInCurrentTxn(callCtx,
reloadedEntity.getEntity());
+ storageIntegration.config();
Review Comment:
I think we could remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
