dimas-b commented on code in PR #2711:
URL: https://github.com/apache/polaris/pull/2711#discussion_r2389585398
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -804,7 +804,14 @@ private LoadTableResponse.Builder
buildLoadTableResponseWithDelegationCredential
credentialDelegation.getAccessConfig(
tableIdentifier, tableMetadata, actions,
refreshCredentialsEndpoint);
Map<String, String> credentialConfig = accessConfig.credentials();
- if (!credentialConfig.isEmpty() &&
delegationModes.contains(VENDED_CREDENTIALS)) {
+ if (delegationModes.contains(VENDED_CREDENTIALS)) {
Review Comment:
`AwsCredentialsStorageIntegration.getSubscopedCreds()` may be called when
STS is disabled (so no credentials will be vended). It's a valid use case for
non-AWS S3 storage. Clients still need non-credential config from the "storage
integration" code (e.g. endpoints).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
