dimas-b commented on code in PR #2711:
URL: https://github.com/apache/polaris/pull/2711#discussion_r2403468798
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -804,13 +804,22 @@ private LoadTableResponse.Builder
buildLoadTableResponseWithDelegationCredential
credentialDelegation.getAccessConfig(
tableIdentifier, tableMetadata, actions,
refreshCredentialsEndpoint);
Map<String, String> credentialConfig = accessConfig.credentials();
- if (!credentialConfig.isEmpty() &&
delegationModes.contains(VENDED_CREDENTIALS)) {
- responseBuilder.addAllConfig(credentialConfig);
- responseBuilder.addCredential(
- ImmutableCredential.builder()
- .prefix(tableMetadata.location())
- .config(credentialConfig)
- .build());
+ if (delegationModes.contains(VENDED_CREDENTIALS)) {
+ if (!credentialConfig.isEmpty()) {
+ responseBuilder.addAllConfig(credentialConfig);
+ responseBuilder.addCredential(
+ ImmutableCredential.builder()
+ .prefix(tableMetadata.location())
+ .config(credentialConfig)
+ .build());
+ } else {
+ Boolean skipCredIndirection =
+
realmConfig.getConfig(FeatureConfiguration.SKIP_CREDENTIAL_SUBSCOPING_INDIRECTION);
+ Preconditions.checkArgument(
+ !accessConfig.supportsCredentialVending() || skipCredIndirection,
+ "Credential vending was requested for table %s, but no
credentials are available",
+ tableIdentifier);
Review Comment:
Sounds reasonable to me.
TBH, I do not like `AccessConfig.supportsCredentialVending()`, but it seemed
to be the simplest way to make the check without breaking other thinks
:sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
