adutra commented on code in PR #2280:
URL: https://github.com/apache/polaris/pull/2280#discussion_r2503692507


##########
polaris-core/src/main/java/org/apache/polaris/core/rest/PolarisResourcePaths.java:
##########
@@ -78,4 +82,15 @@ public String genericTable(TableIdentifier ident) {
         "generic-tables",
         RESTUtil.encodeString(ident.name()));
   }
+
+  public String s3RemoteSigning(TableIdentifier ident) {

Review Comment:
   Well the same could be said for all the methods in this class 😄 
   The package is `org.apache.polaris.core.rest` btw - so I guess REST is a 
core concern 🤷‍♂️ 
   
   I think `PolarisResourcePaths` and `PolarisEndpoints` should not live in 
`core` ideally. But that's the way it is today.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to