adutra commented on code in PR #2280:
URL: https://github.com/apache/polaris/pull/2280#discussion_r2503704682
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -801,6 +806,33 @@ private LoadTableResponse.Builder
buildLoadTableResponseWithDelegationCredential
return responseBuilder;
}
+ AccessDelegationMode delegationMode =
selectAccessDelegationMode(delegationModes);
+
+ if (delegationMode == REMOTE_SIGNING) {
+
+ S3RemoteSigningCatalogHandler.throwIfRemoteSigningNotEnabled(
+ callContext.getRealmConfig(), getResolvedCatalogEntity());
+
+ AccessConfig accessConfig =
+ accessConfigProvider.getAccessConfigForRemoteSigning(
+ callContext, catalogName, tableIdentifier, resolvedStoragePath);
+
+ Map<String, String> credentialConfig = accessConfig.credentials();
+
+ if (!credentialConfig.isEmpty()) {
+ responseBuilder.addAllConfig(credentialConfig);
+ responseBuilder.addCredential(
Review Comment:
Good catch, this doesn't make sense 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
