adutra commented on code in PR #2280:
URL: https://github.com/apache/polaris/pull/2280#discussion_r2511644077
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/common/CatalogHandler.java:
##########
@@ -394,6 +394,47 @@ protected void authorizeRenameTableLikeOperationOrThrow(
initializeCatalog();
}
+ protected void authorizeRemoteSigningOrThrow(
+ EnumSet<PolarisAuthorizableOperation> ops, TableIdentifier identifier) {
+
+ ensureResolutionManifestForTable(identifier);
+ PolarisResolvedPathWrapper target =
+ resolutionManifest.getResolvedPath(
+ identifier, PolarisEntityType.TABLE_LIKE,
PolarisEntitySubType.ICEBERG_TABLE, true);
+
+ // If the table doesn't exist, we still need to check allowed locations
from the parent
+ // namespace.
Review Comment:
Yes. When creating a new table, engines write the manifest files first, then
commit the table. The manifest writes must be signed too. Thus, a request to
sign can arrive at the server before the table is created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
