dimas-b commented on code in PR #3005:
URL: https://github.com/apache/polaris/pull/3005#discussion_r2504267295
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -46,7 +46,7 @@ public static ImmutableAwsStorageConfigurationInfo.Builder
builder() {
// Technically, it should be
^arn:(aws|aws-cn|aws-us-gov):iam::(\d{12}):role/.+$,
@JsonIgnore
- public static final String ROLE_ARN_PATTERN =
"^arn:(aws|aws-us-gov):iam::(\\d{12}):role/.+$";
+ public static final String ROLE_ARN_PATTERN =
"^.+:(.*):iam:.*:(.*):role/.+$";
Review Comment:
actually, the constant name is probably ok as it eventually relates to AWS
SDK terminology... but please add / update the comment to mention that it
applies to non-AWS systems too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
