flyrain commented on code in PR #3005:
URL: https://github.com/apache/polaris/pull/3005#discussion_r2504875719
##########
runtime/service/src/test/java/org/apache/polaris/service/entity/CatalogEntityTest.java:
##########
@@ -255,7 +255,7 @@ public void testValidAllowedLocationPrefix() {
}
@ParameterizedTest
- @ValueSource(strings = {"", "arn:aws:iam::0123456:role/jdoe", "aws-cn"})
+ @ValueSource(strings = {"", "arn:aws:iam:0123456:role/jdoe", "aws-cn"})
Review Comment:
Can we have another test for a valid non-aws role string which can pass the
validation? So that, any regression will be caught if the regex change happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
