dimas-b commented on code in PR #3005:
URL: https://github.com/apache/polaris/pull/3005#discussion_r2504813359
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -44,9 +44,9 @@ public static ImmutableAwsStorageConfigurationInfo.Builder
builder() {
return ImmutableAwsStorageConfigurationInfo.builder();
}
- // Technically, it should be
^arn:(aws|aws-cn|aws-us-gov):iam::(\d{12}):role/.+$,
- @JsonIgnore
- public static final String ROLE_ARN_PATTERN =
"^arn:(aws|aws-us-gov):iam::(\\d{12}):role/.+$";
+ // Technically, it should be
^arn:(aws|aws-cn|aws-us-gov):iam::(\d{12}):role/.+$, but we've
+ // generalized it to support non-aws S3 implementations
+ @JsonIgnore public static final String ROLE_ARN_PATTERN =
"^.+:(.*):iam:.*:(.*):role/.+$";
Review Comment:
yes, having a CHANGELOG entry under `Changes` will not hurt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
