dimas-b commented on code in PR #3188:
URL: https://github.com/apache/polaris/pull/3188#discussion_r2579116524
##########
plugins/spark/v3.5/integration/build.gradle.kts:
##########
@@ -35,6 +35,14 @@ val scalaLibraryVersion =
pluginlibs.versions.scala213.get()
}
+configurations.all {
+ if (name != "checkstyle") {
+ resolutionStrategy {
+ force("org.antlr:antlr4-runtime:4.9.3") // Spark 3.5 and Delta 3.3
require ANTLR 4.9.3
Review Comment:
Why do we have to force this version? Who tries to make it different and why?
##########
plugins/spark/v3.5/integration/build.gradle.kts:
##########
@@ -91,7 +99,7 @@ dependencies {
testImplementation(enforcedPlatform("org.scala-lang:scala-library:${scalaLibraryVersion}"))
testImplementation(enforcedPlatform("org.scala-lang:scala-reflect:${scalaLibraryVersion}"))
testImplementation(libs.javax.servlet.api)
- testImplementation(libs.antlr4.runtime)
+ // ANTLR version is determined by Spark/Delta dependencies, not enforced
Review Comment:
nit: this comment will be hard to understand after this PR is merged 🤔 it
might be preferable to move it to a GH comment instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
