gh-yzou commented on code in PR #3188:
URL: https://github.com/apache/polaris/pull/3188#discussion_r2583063715
##########
settings.gradle.kts:
##########
@@ -68,7 +68,15 @@ val sparkVersions =
sparkScalaVersions["sparkVersions"].toString().split(",").ma
val noSourceChecksProjects = mutableSetOf<String>()
for (sparkVersion in sparkVersions) {
- val scalaVersions =
sparkScalaVersions["scalaVersions"].toString().split(",").map { it.trim() }
+ // Check if there's a version-specific scalaVersions property, otherwise use
the default
+ val scalaVersionsKey = "scalaVersions.${sparkVersion}"
+ val scalaVersionsStr =
+ if (sparkScalaVersions.containsKey(scalaVersionsKey)) {
Review Comment:
if we update it to all spark version specific, i don't think we need the if
here anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
