adam-christian-software commented on code in PR #3188:
URL: https://github.com/apache/polaris/pull/3188#discussion_r2593927476
##########
plugins/spark/v3.5/integration/build.gradle.kts:
##########
@@ -35,6 +35,14 @@ val scalaLibraryVersion =
pluginlibs.versions.scala213.get()
}
+configurations.all {
+ if (name != "checkstyle") {
+ resolutionStrategy {
+ force("org.antlr:antlr4-runtime:4.9.3") // Spark 3.5 and Delta 3.3
require ANTLR 4.9.3
Review Comment:
So, we have an issue where our integration tests rely on Spark 3.5. Spark
3.5 relies on Spark 3.5 requires ANTLR 4.9.3. Spark 4.0 relies on ANTLR 4.13.1.
This was one way to handle this, but there actually might be a cleaner way
by putting this in pluginlibs.versions.toml. I'll try that.
##########
plugins/spark/v3.5/README.md:
##########
@@ -0,0 +1,127 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Polaris Spark 3.5 Plugin
+
+The Polaris Spark plugin provides a SparkCatalog class, which communicates
with the Polaris
+REST endpoints, and provides implementations for Apache Spark's
+[TableCatalog](https://github.com/apache/spark/blob/v3.5.6/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java),
+[ViewCatalog](https://github.com/apache/spark/blob/v3.5.6/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ViewCatalog.java)
classes.
+[SupportsNamespaces](https://github.com/apache/spark/blob/v3.5.6/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsNamespaces.java),
+
+Right now, the plugin only provides support for Spark 3.5, Scala version 2.12
and 2.13,
+and depends on iceberg-spark-runtime 1.9.1.
Review Comment:
Sorry, I just merged upstream in and it looks like the Iceberg version is
the same now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
