dimas-b commented on code in PR #3324:
URL: https://github.com/apache/polaris/pull/3324#discussion_r2662051374
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##########
@@ -39,11 +39,26 @@ public interface PolarisConfigurationStore {
/**
* Retrieve the current value for a configuration key for a given realm. May
be null if not set.
*
+ * <p>This method is meant to be overridden by concrete configuration store
implementations. This
+ * method is not meant to be calls by code that needs access to
configuration values.
+ * Configuration consumers should call typed methods that take a {@link
PolarisConfiguration}
+ * parameter instead.
Review Comment:
I reformatted the javadoc, hoping to emphasize the need to use typed methods.
TBH, I'm not sure whether the "prefer" suggestion is targeting callers or
implementors 🤔 WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
