dimas-b commented on code in PR #3324:
URL: https://github.com/apache/polaris/pull/3324#discussion_r2662182913
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##########
@@ -39,11 +39,27 @@ public interface PolarisConfigurationStore {
/**
* Retrieve the current value for a configuration key for a given realm. May
be null if not set.
*
+ * <p>This method is meant to be overridden by concrete configuration store
implementations.
Review Comment:
Good point. I've been thinking about splitting this into an API/SPI pair
too, but I thought it might be too intrusive... Let me actually try that
refactoring and see what's impacted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]