snazy commented on code in PR #3324:
URL: https://github.com/apache/polaris/pull/3324#discussion_r2662162833
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##########
@@ -39,11 +39,27 @@ public interface PolarisConfigurationStore {
/**
* Retrieve the current value for a configuration key for a given realm. May
be null if not set.
*
+ * <p>This method is meant to be overridden by concrete configuration store
implementations.
Review Comment:
Actually, I wonder whether this function and the `getConfiguration`
functions should have a default implementation at all. Wouldn't it be cleaner
to move that to the actual implementation? Mean, this `interface` isn't really
an interface but rather a not-really abstract class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
