[jira] [Commented] (ROCKETMQ-138) Add AuthenticationException class to remove hard coded Aliyun authentication class

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906884#comment-15906884
 ] 

ASF GitHub Bot commented on ROCKETMQ-138:
-----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/75
  
    
    [![Coverage 
Status](https://coveralls.io/builds/10557748/badge)](https://coveralls.io/builds/10557748)
    
    Coverage decreased (-0.04%) to 30.971% when pulling 
**e8104c0b89fb7b3527d24d99d2de358a82e91e36 on 
Jaskey:ROCKETMQ-138-AuthenticationException** into 
**d7decc84abc32dab63ee423d4d904f28d18cb1d7 on apache:develop**.



> Add AuthenticationException class to remove hard coded Aliyun authentication 
> class
> ----------------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-138
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-138
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-remoting
>            Reporter: Jaskey Lam
>            Assignee: Jaskey Lam
>            Priority: Minor
>
> in NettyRemotingAbstract.java
> a hard coded aliyun class is used 
> {code}
> catch (Throwable e) {
>                         if 
> (!"com.aliyun.openservices.ons.api.impl.authority.exception.AuthenticationException"
>                             .equals(e.getClass().getCanonicalName())) {
>                             PLOG.error("process request exception", e);
>                             PLOG.error(cmd.toString());
>                         }
> {code}
> A common AuthenticationException should be added to identify Authentication 
> failure.  Developers can throw this exception so that remoting component can 
> ignore it



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)