[ https://issues.apache.org/jira/browse/ROCKETMQ-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942696#comment-15942696 ]
ASF GitHub Bot commented on ROCKETMQ-138: ----------------------------------------- Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/75 LGTM > Add AuthenticationException class to remove hard coded Aliyun authentication > class > ---------------------------------------------------------------------------------- > > Key: ROCKETMQ-138 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-138 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-remoting > Reporter: Jaskey Lam > Assignee: Jaskey Lam > Priority: Minor > > in NettyRemotingAbstract.java > a hard coded aliyun class is used > {code} > catch (Throwable e) { > if > (!"com.aliyun.openservices.ons.api.impl.authority.exception.AuthenticationException" > .equals(e.getClass().getCanonicalName())) { > PLOG.error("process request exception", e); > PLOG.error(cmd.toString()); > } > {code} > A common AuthenticationException should be added to identify Authentication > failure. Developers can throw this exception so that remoting component can > ignore it -- This message was sent by Atlassian JIRA (v6.3.15#6346)