[
https://issues.apache.org/jira/browse/ROCKETMQ-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942861#comment-15942861
]
ASF GitHub Bot commented on ROCKETMQ-138:
-----------------------------------------
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
Do you guys really consider that is good enough?? @vongosling @lollipopjin
IMO, the origin design is OK, since the AuthenticationException is thrown
from the hook.
The devs will log their own Authentication fail log already (may be print
periodically or somehow ), but rocketmq remoting should only care about the
real error.
If we remove it, all authentication fail will have one log, and this could
be possibly very often and fill up with the remoting log, which I do not think
it is good enough.
User should care about their custom authentication log, and remoting
component should care about real error thrown from the processor.
> Add AuthenticationException class to remove hard coded Aliyun authentication
> class
> ----------------------------------------------------------------------------------
>
> Key: ROCKETMQ-138
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-138
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-remoting
> Reporter: Jaskey Lam
> Assignee: Jaskey Lam
> Priority: Minor
>
> in NettyRemotingAbstract.java
> a hard coded aliyun class is used
> {code}
> catch (Throwable e) {
> if
> (!"com.aliyun.openservices.ons.api.impl.authority.exception.AuthenticationException"
> .equals(e.getClass().getCanonicalName())) {
> PLOG.error("process request exception", e);
> PLOG.error(cmd.toString());
> }
> {code}
> A common AuthenticationException should be added to identify Authentication
> failure. Developers can throw this exception so that remoting component can
> ignore it
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
