Copilot commented on code in PR #589:
URL: https://github.com/apache/sedona-db/pull/589#discussion_r2793637360
##########
rust/sedona-schema/src/raster.rs:
##########
@@ -88,19 +88,23 @@ impl RasterSchema {
/// Band data type enumeration for raster bands.
///
+/// Values align with GDALDataType ordinals for non-complex types (excluding
Unknown).
/// Only supports basic numeric types.
/// In future versions, consider support for complex types used in
/// radar and other wave-based data.
Review Comment:
The comment states ordinals align with GDAL's non-complex types 'excluding
Unknown', but the mapping is incomplete. GDAL ordinals 8-11 (CInt16, CInt32,
CFloat32, CFloat64) are skipped without explanation. Consider clarifying that
this enum only includes real-valued types and omits both GDT_Unknown (0) and
all complex types (8-11).
```suggestion
/// Discriminant values 1–7 align with `GDALDataType` ordinals for
real-valued
/// (non-complex) types. `GDT_Unknown` (0) and all complex types (8–11) are
/// intentionally omitted. Values 12–14 are Sedona-specific extensions that
do
/// not correspond to any `GDALDataType` value.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
