Kontinuation commented on code in PR #589:
URL: https://github.com/apache/sedona-db/pull/589#discussion_r2797683416
##########
rust/sedona-schema/src/raster.rs:
##########
@@ -88,19 +88,22 @@ impl RasterSchema {
/// Band data type enumeration for raster bands.
///
-/// Only supports basic numeric types.
-/// In future versions, consider support for complex types used in
-/// radar and other wave-based data.
+/// Ordinals match GDALDataType for real-valued pixel types only.
+/// GDT_Unknown (0) and complex types (CInt16=8, CInt32=9, CFloat32=10,
CFloat64=11)
+/// are intentionally omitted.
#[repr(u16)]
-#[derive(Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq, Hash, Copy)]
pub enum BandDataType {
Review Comment:
The values here were happened to be the same as GDAL band data types. We'll
have functions for converting between then rather than implicitly relying on
it.
https://github.com/Kontinuation/sedona-db/blob/0e73e17a79332cf7e58b9881084d86dd3f3531c1/rust/sedona-raster-gdal/src/gdal_common.rs#L50-L88
I decided to simply define the values without GDAL awareness just as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
