Kontinuation commented on code in PR #589:
URL: https://github.com/apache/sedona-db/pull/589#discussion_r2797689058
##########
rust/sedona-raster/src/array.rs:
##########
@@ -146,13 +146,16 @@ impl<'a> BandMetadataRef for BandMetadataRefImpl<'a> {
fn data_type(&self) -> BandDataType {
match self.datatype_array.value(self.band_index) {
- 0 => BandDataType::UInt8,
- 1 => BandDataType::UInt16,
- 2 => BandDataType::Int16,
- 3 => BandDataType::UInt32,
- 4 => BandDataType::Int32,
- 5 => BandDataType::Float32,
- 6 => BandDataType::Float64,
+ 1 => BandDataType::UInt8,
+ 2 => BandDataType::UInt16,
+ 3 => BandDataType::Int16,
+ 4 => BandDataType::UInt32,
+ 5 => BandDataType::Int32,
+ 6 => BandDataType::Float32,
+ 7 => BandDataType::Float64,
+ 12 => BandDataType::UInt64,
+ 13 => BandDataType::Int64,
+ 14 => BandDataType::Int8,
_ => panic!(
"Unknown band data type: {}",
Review Comment:
Sure. I found that storage_type also need to be fixed, I have changed both
storage_type() and data_type() to return Result<...>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
