desruisseaux commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2832325641
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java:
##########
@@ -107,6 +146,31 @@ public class FileService extends FileSystemProvider {
*/
public static final String AWS_SECRET_ACCESS_KEY = "aws.secretAccessKey";
+ /**
+ * The property for the host (mandatory if not using AWS S3).
+ * Values shall be instances of {@link String}.
+ *
+ * @see #newFileSystem(URI, Map)
+ */
Review Comment:
All public or protected fields or methods added in this pull request need a
`@since 1.7` tag. Private fields do not need this tag. That tag should be last
(below the `@see` tag). While not mandatory, this is the usual order in Java
conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
