desruisseaux commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2832389769


##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java:
##########
@@ -724,6 +749,15 @@ public String toString() {
             if (fs.accessKey != null) {
                 sb.append(fs.accessKey).append('@');
             }
+
+            if (fs.host != null) {
+                if(fs.port < 0) {

Review Comment:
   Missing space after `if`. Can also be simplified, because 
`sb.append(fs.host)` is always done first and `sb.append("/")` is always done 
last. In addition, `sb.append("/")` and be replaced by the slightly more 
efficient `sb.append('/')`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to