gerlowskija commented on a change in pull request #39: URL: https://github.com/apache/solr/pull/39#discussion_r623196200
########## File path: solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepository.java ########## @@ -142,6 +142,7 @@ default String getBackupLocation(String override) { */ OutputStream createOutput(URI path) throws IOException; + // TODO define whether this should also create any nonexistent parent directories. (i.e. is this 'mkdir', or 'mkdir -p') Review comment: Huh, that could've been from the incremental-backup support that I added a few months back, but that wasn't my intention. And it's been a bit since I ran this test, but I was nearly certain that LocalFileSystemRepository would error-out if a parent directory was missing. But if that's what you're seeing, it's hard to argue with. Any chance you still have a stacktrace handy that shows where that error cropped up in Solr's backup code? (Might be worth continuing this discussion on SOLR-15089 or SOLR-15359 since JIRA is a little more durable/find-able than these PRs. But I'll try to remember to check back both places ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org