athrog commented on a change in pull request #39:
URL: https://github.com/apache/solr/pull/39#discussion_r623428282
##########
File path:
solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepository.java
##########
@@ -142,6 +142,7 @@ default String getBackupLocation(String override) {
*/
OutputStream createOutput(URI path) throws IOException;
+ // TODO define whether this should also create any nonexistent parent
directories. (i.e. is this 'mkdir', or 'mkdir -p')
Review comment:
I realize I misread your ask for the stacktrace -- you're looking for
where in Solr code someone's asking for a subdir and assuming `mkdir -p`
behavior. Here it is:
```
2021-04-29 21:49:16.472 INFO
(OverseerThreadFactory-15-thread-2-processing-n:localhost:8983_solr)
[c:collection1619732944 ] o.a.s.c.a.c.BackupCmd Starting to backup ZK data
for backupName=backup1619732944
2021-04-29 21:49:16.481 ERROR
(OverseerThreadFactory-15-thread-2-processing-n:localhost:8983_solr)
[c:collection1619732944 ] o.a.s.c.a.c.OverseerCollectionMessageHandler
Collection: collection1619732944 operation: backup failed:java.io.IOException:
org.apache.solr.blob.client.BlobException: Parent directory doesn't exist,
path=foo/backup1619732944/collection1619732944/zk_backup_0/
at
org.apache.solr.blob.backup.BlobBackupRepository.createDirectory(BlobBackupRepository.java:120)
at
org.apache.solr.core.backup.BackupManager.downloadConfigDir(BackupManager.java:249)
at
org.apache.solr.cloud.api.collections.BackupCmd.call(BackupCmd.java:124)
at
org.apache.solr.cloud.api.collections.OverseerCollectionMessageHandler.processMessage(OverseerCollectionMessageHandler.java:117)
at
org.apache.solr.cloud.OverseerTaskProcessor$Runner.run(OverseerTaskProcessor.java:531)
at
org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:226)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
```
And you're right, makes more sense to continue the discussion on SOLR-15359,
since this PR is closed now. I'll copy this comment over there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
