athrog commented on a change in pull request #39:
URL: https://github.com/apache/solr/pull/39#discussion_r623422697
##########
File path:
solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepository.java
##########
@@ -142,6 +142,7 @@ default String getBackupLocation(String override) {
*/
OutputStream createOutput(URI path) throws IOException;
+ // TODO define whether this should also create any nonexistent parent
directories. (i.e. is this 'mkdir', or 'mkdir -p')
Review comment:
Oh -- the stacktrace I was referring to is thrown from our code.
Basically, we check if the parent dir exists when creating a dir, and throw an
exception if it's not there.
If I send this backup cmd to 8.2 and 9.0
`/solr/admin/collections?action=BACKUP&repository=blob&location=blob:/foo&collection=$COLLECTION&name=$BACKUP_NAME`
In 8.2, all the files are under $BACKUP_NAME, but in 9.0 all files are under
$BACKUP_NAME/$COLLECTION.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
