madrob commented on a change in pull request #165:
URL: https://github.com/apache/solr/pull/165#discussion_r646649789



##########
File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java
##########
@@ -204,9 +204,9 @@ public final ConfigSet loadConfigSet(CoreDescriptor dcore) {
     try {
 
       // ConfigSet properties are loaded from 
ConfigSetProperties.DEFAULT_FILENAME file.
-      NamedList properties = loadConfigSetProperties(dcore, coreLoader);
+      NamedList<Object> properties = loadConfigSetProperties(dcore, 
coreLoader);

Review comment:
       We have to pass the properties on to a ConfigSet, it's easier to just 
deal with it as Object.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to