madrob commented on a change in pull request #165:
URL: https://github.com/apache/solr/pull/165#discussion_r646926666
##########
File path: solr/core/src/java/org/apache/solr/api/ApiBag.java
##########
@@ -301,19 +301,18 @@ public static SpecProvider constructSpec(PluginInfo info)
{
Object specObj = info == null ? null : info.attributes.get("spec");
if (specObj == null) specObj = "emptySpec";
if (specObj instanceof Map) {
- @SuppressWarnings({"rawtypes"})
- Map map = (Map) specObj;
+ assert false : "got a map from a string";
Review comment:
So there's actually something pretty horrible going on here, at
PluginInfo line 141
(https://github.com/apache/solr/pull/165/files#diff-ed395ffeb39b23f571cff745a84a590312d3cceb3ef91ff9123e6cdcf4b7d14aL141)
where we wrap the existing `Map<String,Object> initArgs` as
`Map<String,String> attributes`. Then when we pull this spec through in ApiBag
and lots of places around core initialization. It's a big issue but I think it
needs to be handled separately from the rest of the raw types since I suspect
there will be lots of changes as we figure out how to untangle it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
