dsmiley commented on a change in pull request #165:
URL: https://github.com/apache/solr/pull/165#discussion_r646971932
##########
File path:
solr/core/src/java/org/apache/solr/util/plugin/NamedListInitializedPlugin.java
##########
@@ -25,5 +25,10 @@
* @since solr 1.3
*/
public interface NamedListInitializedPlugin {
- void init( @SuppressWarnings({"rawtypes"})NamedList args );
+ /**
+ * <code>init</code> will be called just once, immediately after creation.
+ * <p>The args are user-level initialization parameters that
+ * may be specified, usually in solrconfig.xml
+ */
+ default void init(NamedList<?> args) {}
Review comment:
Your change is fine, given how it's used today. I was contemplating a
different future where this interface is totally opt-in, and I'm not sure since
it's rather common for plugin abstractions to declare such an init method any
way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
