cpoerschke commented on a change in pull request #166:
URL: https://github.com/apache/solr/pull/166#discussion_r654630147
##########
File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRScoringQuery.java
##########
@@ -223,6 +223,7 @@ public ModelWeight createWeight(IndexSearcher searcher,
ScoreMode scoreMode, flo
else{
createWeightsParallel(searcher, scoreMode.needsScores(), featureWeights,
features);
}
+ // TODO: potential prefetchFields computation site?
Review comment:
> ... My only concern is the re-computation per query. ...
Excellent point! And it got me thinking about additional alternative
approaches and so here's another one for the list, one _without_ the per-query
re-computation but _with_ the per-query precision.
LTRScoringModel (also) computes joint `prefetchFields` approach:
* (+) the feature store content provides visibility into the feature store's
overall prefetch fields set
* (+) the used prefetch fields used is 'precise' i.e. all features in the
store vs. all features used by the model
* (+) thrown exceptions can provide visibility into the 'precise' prefetch
fields used
* (+/-) concurrency needs to be considered when updating the prefetch fields
of actively used features
partial code illustration:
https://github.com/cpoerschke/solr/commit/de4e32fa21b9daba34b6b297e770e1c2c29362b0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
