tomglk commented on a change in pull request #166:
URL: https://github.com/apache/solr/pull/166#discussion_r656418979
##########
File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRScoringQuery.java
##########
@@ -223,6 +223,7 @@ public ModelWeight createWeight(IndexSearcher searcher,
ScoreMode scoreMode, flo
else{
createWeightsParallel(searcher, scoreMode.needsScores(), featureWeights,
features);
}
+ // TODO: potential prefetchFields computation site?
Review comment:
> if the setField and setIndex calls in the clone() method were a key
part to fix the tests
They were essential to make the tests work. I never heard about `Clonable`,
but that sounds like we could use it here. :)
> 69c6611 tries that out, what do you think?
I can see where you are coming from, but to be honest I am not really a fan
of this change.
Yes, it makes the code more comprehensive. But my problem is, that now we
just throw a generic `UnsupportedOperationException` instead of providing more
information about the cause like we did with the custom message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
