cpoerschke commented on a change in pull request #166:
URL: https://github.com/apache/solr/pull/166#discussion_r656402593
##########
File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRScoringQuery.java
##########
@@ -223,6 +223,7 @@ public ModelWeight createWeight(IndexSearcher searcher,
ScoreMode scoreMode, flo
else{
createWeightsParallel(searcher, scoreMode.needsScores(), featureWeights,
features);
}
+ // TODO: potential prefetchFields computation site?
Review comment:
> ... Also, I did a few small changes to fix the tests ...
Thanks! I'm not sure if the `setField` and `setIndex` calls in the `clone()`
method were a key part to fix the tests but seeing them made me wonder if we
need to give a clone method to the super class or declare the class(es)
`Cloneable` since both field and index are not specific to the PFVF class.
> ... some renaming because the terms `frozen` and `freeze` made it a bit
hard to understand.)
Yes, those terms were a bit generic. Upon further thought it seems that Java
Collection's _unmodifiable_ concept is a good match here --
https://github.com/apache/solr/pull/166/commits/69c6611c467b8129bd31ea7527f091f734d1e3b2
tries that out, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
