cpoerschke commented on a change in pull request #196: URL: https://github.com/apache/solr/pull/196#discussion_r660122371
########## File path: solr/core/src/test/org/apache/solr/TestRandomDVFaceting.java ########## @@ -125,7 +125,7 @@ void deleteSomeDocs() { int percent = rand.nextInt(100); if (model == null) return; ArrayList<String> ids = new ArrayList<>(model.size()); - for (@SuppressWarnings({"rawtypes"})Comparable id : model.keySet()) { + for (Comparable<?> id : model.keySet()) { Review comment: observation: `model` itself retains its rawtypes suppress warnings for now. ########## File path: solr/core/src/test/org/apache/solr/util/SolrPluginUtilsTest.java ########## @@ -248,7 +248,7 @@ public void testDisjunctionMaxQueryParser() throws Exception { } - private static int countItems(@SuppressWarnings({"rawtypes"})Iterator i) { + private static int countItems(Iterator<?> i) { Review comment: ```suggestion private static int countItems(Iterator<Query> i) { ``` might work here, i haven't tried, but with quantity vs. quality considerations in mind in this cleanup and since this is a private static method in test code either is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org