markrmiller commented on a change in pull request #225:
URL: https://github.com/apache/solr/pull/225#discussion_r711464755



##########
File path: solr/core/src/java/org/apache/solr/analysis/TokenizerChain.java
##########
@@ -49,7 +49,6 @@ public TokenizerChain(CustomAnalyzer customAnalyzer) {
         customAnalyzer.getTokenizerFactory(),
         customAnalyzer.getTokenFilterFactories().toArray(new 
TokenFilterFactory[0]));
     setPositionIncrementGap(customAnalyzer.getPositionIncrementGap(null));
-    setVersion(customAnalyzer.getVersion());

Review comment:
       Yeah, initially I left it as a nocommit figuring it must have moved or 
something, but root issue essentially says, this has not been used in a long 
time, didn't work very well when it was used, just removing it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to