madrob commented on a change in pull request #225:
URL: https://github.com/apache/solr/pull/225#discussion_r718861026
##########
File path: solr/core/src/test/org/apache/solr/search/FuzzySearchTest.java
##########
@@ -17,19 +17,12 @@
package org.apache.solr.search;
-import java.io.IOException;
-
import org.apache.lucene.util.LuceneTestCase;
-import org.apache.solr.client.solrj.SolrQuery;
-import org.apache.solr.client.solrj.SolrServerException;
-import org.apache.solr.client.solrj.impl.BaseHttpSolrClient;
import org.apache.solr.client.solrj.impl.CloudSolrClient;
import org.apache.solr.client.solrj.request.CollectionAdminRequest;
import org.apache.solr.cloud.SolrCloudTestCase;
-import org.apache.solr.common.SolrInputDocument;
import org.junit.Before;
import org.junit.BeforeClass;
-import org.junit.Test;
@LuceneTestCase.Slow
public class FuzzySearchTest extends SolrCloudTestCase {
Review comment:
There are no other tests in this class, remove the whole file.
##########
File path: solr/core/src/test/org/apache/solr/update/SolrIndexConfigTest.java
##########
@@ -92,7 +92,6 @@ public void testTieredMPSolrIndexConfigCreation() throws
Exception {
assertNotNull("null mp", iwc.getMergePolicy());
assertTrue("mp is not TieredMergePolicy", iwc.getMergePolicy() instanceof
TieredMergePolicy);
TieredMergePolicy mp = (TieredMergePolicy) iwc.getMergePolicy();
- assertEquals("mp.maxMergeAtOnceExplicit", 19,
mp.getMaxMergeAtOnceExplicit());
Review comment:
can still check `maxMergeAtOnce`?
##########
File path: solr/core/src/test/org/apache/solr/search/TestSolrCoreParser.java
##########
@@ -146,10 +138,10 @@ public void testHandySpanQuery() throws IOException,
ParserException {
final Query clauseQuery = bq.clauses().get(ii).getQuery();
switch (ii) {
case 0:
- assertTrue(unwrapSpanBoostQuery(clauseQuery) instanceof SpanOrQuery);
+ assertTrue(clauseQuery instanceof SpanOrQuery);
Review comment:
we can leave it to be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
