madrob commented on a change in pull request #225: URL: https://github.com/apache/solr/pull/225#discussion_r713970122
########## File path: solr/core/src/java/org/apache/solr/spelling/suggest/jaspell/JaspellLookup.java ########## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.spelling.suggest.jaspell; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; +import java.util.Set; +import org.apache.lucene.search.suggest.InputIterator; +import org.apache.lucene.search.suggest.Lookup; +import org.apache.lucene.store.DataInput; +import org.apache.lucene.store.DataOutput; +import org.apache.lucene.util.BytesRef; +import org.apache.lucene.util.CharsRef; +import org.apache.lucene.util.CharsRefBuilder; +import org.apache.solr.spelling.suggest.jaspell.JaspellTernarySearchTrie.TSTNode; + +/** + * Suggest implementation based on <a href="http://jaspell.sourceforge.net/";>JaSpell</a>. + * + * @see JaspellTernarySearchTrie + * @deprecated Migrate to one of the newer suggesters which are much more RAM efficient. + */ +@Deprecated +public class JaspellLookup extends Lookup { Review comment: Do we have to keep this around? ########## File path: solr/core/src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java ########## @@ -972,12 +972,10 @@ public boolean incrementToken() throws IOException { } } - /** - * Wraps a DirectoryReader that caches the {@link LeafReader#getTermVectors(int)} so that - * if the next call has the same ID, then it is reused. - */ Review comment: Why did this javadoc go away? ########## File path: solr/core/src/test/org/apache/solr/search/TestDocSet.java ########## @@ -287,6 +287,11 @@ public int maxDoc() { return maxDoc; } + @Override + public Fields getTermVectors(int docID) throws IOException { Review comment: nit: I don't think we have to declare as throwing IOEx here. (and again later) ########## File path: solr/core/src/java/org/apache/solr/search/similarities/BM25SimilarityFactory.java ########## @@ -24,7 +24,7 @@ /** * Factory for BM25Similarity. This is the default similarity since 8.x. * If you need the exact same formula as in 6.x and 7.x you should instead look at - * {@link LegacyBM25SimilarityFactory} noting that it is deprecated as of 8.10.0 + * LegacyBM25SimilarityFactory noting that it is deprecated as of 8.10.0 * and will be removed in 9.x. Review comment: I would remove this entirely. ########## File path: solr/core/src/test/org/apache/solr/search/TestSolrCoreParser.java ########## @@ -146,10 +138,10 @@ public void testHandySpanQuery() throws IOException, ParserException { final Query clauseQuery = bq.clauses().get(ii).getQuery(); switch (ii) { case 0: - assertTrue(unwrapSpanBoostQuery(clauseQuery) instanceof SpanOrQuery); + assertTrue(clauseQuery instanceof SpanOrQuery); Review comment: personal preference ```suggestion assertThat(query, Matchers.instanceOf(SpanOrQuery)); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
