janhoy commented on a change in pull request #372:
URL: https://github.com/apache/solr/pull/372#discussion_r742819554
##########
File path: solr/core/src/java/org/apache/solr/handler/admin/LoggingHandler.java
##########
@@ -168,4 +169,8 @@ public Category getCategory() {
return Category.ADMIN;
}
+ @Override
+ public Name getPermissionName(AuthorizationContext request) {
+ return Name.CONFIG_READ_PERM;
Review comment:
Actually, I found a bug here while testing. Turns out that `InfoHandler`
is hack and contains an internal map of its sub handlers like LoggingHandler.
I had to add custom code to `getPermissionName()` and delgate the call to
the actual sub handler. Now it seems to work.
E.g. in admin UI you cannot change log-level unless you have config-edit
permission. But there is no clear error-message in UI (yet), only the standard
red box on top. Granular HTTP 403 errors in UI can come later. Perhpas you have
something planned, @thelabdude ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
