janhoy commented on a change in pull request #372: URL: https://github.com/apache/solr/pull/372#discussion_r742992355
########## File path: solr/core/src/java/org/apache/solr/handler/PingRequestHandler.java ########## @@ -133,6 +134,12 @@ private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); public static final String HEALTHCHECK_FILE_PARAM = "healthcheckFile"; + + @Override + public Name getPermissionName(AuthorizationContext request) { + return Name.HEALTH_PERM; Review comment: Thinking about this - should we rather use `metrics-read` here instead of inventing a new permission? Health status is one type of metric.. Only reason to distinguish is if you simply want to allow an external Load Balancer or something to know whether Solr is alive, but don't want to leak all metrics... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org