janhoy commented on a change in pull request #372:
URL: https://github.com/apache/solr/pull/372#discussion_r742975679
##########
File path:
solr/core/src/java/org/apache/solr/handler/admin/SegmentsInfoRequestHandler.java
##########
@@ -434,4 +435,9 @@ public String getDescription() {
public Category getCategory() {
return Category.ADMIN;
}
+
+ @Override
+ public Name getPermissionName(AuthorizationContext request) {
+ return Name.CONFIG_READ_PERM;
Review comment:
I had to change the predefined perm `METRICS_READ_PERM` to `'*' or null`
so that it will work both for node-level handler and for collection-level
handler such as <coll>/admin/segments. This authz system is quite trappy!
So now the segments handler is guarded by metrics-read. I also tested the
ping handler, and it is guarded by the new 'health' permission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
