mkhludnev commented on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-961963576
> the problem here was that we end up calling close too many times, right? Exactly `SRI.closeHook()` is invoked twice, one from the request thread, the second one due to cleaning pool's thread. > if we call close on the hook multiple times we could log about it instead of silently ignoring the other times. That's almost what's done in wrapper for closeable. PR: https://github.com/mkhludnev/solr/commit/36fd4aa0d6d98cb4a8db25d5add99aee599c9535#diff-7b4f31855280c776cee1dde2117f04a2fa9fcaf971d2a1b15cfd3f9978896394R210 ok. I can move ``AtomicBoolean closed`` into SRI. And then, you propose to just log it, without preventing closing core? How it helps users who have core closed after `/export?q={!join}`? > clean closing SRI is fine because it's supposed to be mirrored by creating a new entry on the SRI stack during set. Not really. We have single SRI instance, it get into request's thread stack and into pool's thread stack. That's how single SRI have `set` twice. Both stacks should be clean for sure, but closeables needs to be invoked once in IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
